Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: import go-redis to core as replacement of redigo #16492

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

chlins
Copy link
Member

@chlins chlins commented Mar 9, 2022

Closes: #16455

Signed-off-by: chlins chenyuzh@vmware.com

@chlins chlins force-pushed the refactor/replace-core-redis-lib branch from 48480b1 to e876bd1 Compare March 9, 2022 03:35
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #16492 (5be0b93) into main (7d9a117) will decrease coverage by 0.03%.
The diff coverage is 54.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16492      +/-   ##
==========================================
- Coverage   67.41%   67.38%   -0.04%     
==========================================
  Files         949      951       +2     
  Lines       78812    78909      +97     
  Branches     2319     2321       +2     
==========================================
+ Hits        53134    53174      +40     
- Misses      22126    22176      +50     
- Partials     3552     3559       +7     
Flag Coverage Δ
unittests 67.38% <54.71%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/health/checker.go 26.92% <0.00%> (+0.50%) ⬆️
src/controller/proxy/controller.go 15.62% <0.00%> (ø)
src/controller/proxy/manifestcache.go 25.26% <0.00%> (ø)
src/controller/scanner/base_controller.go 37.50% <0.00%> (ø)
src/lib/orm/orm.go 63.80% <0.00%> (-2.53%) ⬇️
src/pkg/config/db/cache.go 53.84% <0.00%> (ø)
src/lib/cache/redis/redis.go 58.00% <48.38%> (-28.96%) ⬇️
src/lib/cache/redis/util.go 59.09% <59.09%> (ø)
src/lib/redis/instance.go 77.77% <77.77%> (ø)
src/controller/blob/controller.go 72.79% <100.00%> (+1.26%) ⬆️
... and 13 more

@chlins chlins force-pushed the refactor/replace-core-redis-lib branch 5 times, most recently from da8a96e to 70eaf5d Compare March 10, 2022 06:25
src/lib/orm/orm.go Outdated Show resolved Hide resolved
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins force-pushed the refactor/replace-core-redis-lib branch from 70eaf5d to c095fbb Compare March 15, 2022 09:38
Signed-off-by: chlins <chenyuzh@vmware.com>
@chlins chlins force-pushed the refactor/replace-core-redis-lib branch from c095fbb to 5be0b93 Compare March 15, 2022 12:45
@chlins chlins merged commit 846dc94 into goharbor:main Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace harbor-core redis library.
3 participants