-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: import go-redis to core as replacement of redigo #16492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlins
force-pushed
the
refactor/replace-core-redis-lib
branch
from
March 9, 2022 03:35
48480b1
to
e876bd1
Compare
Codecov Report
@@ Coverage Diff @@
## main #16492 +/- ##
==========================================
- Coverage 67.41% 67.38% -0.04%
==========================================
Files 949 951 +2
Lines 78812 78909 +97
Branches 2319 2321 +2
==========================================
+ Hits 53134 53174 +40
- Misses 22126 22176 +50
- Partials 3552 3559 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chlins
force-pushed
the
refactor/replace-core-redis-lib
branch
5 times, most recently
from
March 10, 2022 06:25
da8a96e
to
70eaf5d
Compare
stonezdj
reviewed
Mar 11, 2022
stonezdj
approved these changes
Mar 11, 2022
wy65701436
reviewed
Mar 15, 2022
wy65701436
reviewed
Mar 15, 2022
wy65701436
reviewed
Mar 15, 2022
wy65701436
reviewed
Mar 15, 2022
wy65701436
reviewed
Mar 15, 2022
wy65701436
reviewed
Mar 15, 2022
wy65701436
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
chlins
force-pushed
the
refactor/replace-core-redis-lib
branch
from
March 15, 2022 09:38
70eaf5d
to
c095fbb
Compare
Signed-off-by: chlins <chenyuzh@vmware.com>
chlins
force-pushed
the
refactor/replace-core-redis-lib
branch
from
March 15, 2022 12:45
c095fbb
to
5be0b93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #16455
Signed-off-by: chlins chenyuzh@vmware.com