add transaction for artifact delete #16506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #16506 +/- ##
==========================================
- Coverage 67.44% 67.28% -0.17%
==========================================
Files 949 949
Lines 78812 78382 -430
Branches 2321 2321
==========================================
- Hits 53158 52742 -416
+ Misses 22105 22093 -12
+ Partials 3549 3547 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
heww
reviewed
Mar 10, 2022
| @@ -311,7 +311,12 @@ func (c *controller) Delete(ctx context.Context, id int64) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| return c.deleteDeeply(ctx, id, true, len(accs) > 0) | |||
| if err := orm.WithTransaction(func(ctx context.Context) error { | |||
There was a problem hiding this comment.
return orm.WithTransaction(func(ctx context.Context) error {
return c.deleteDeeply(ctx, id, true, len(accs) > 0)
})(orm.SetTransactionOpNameToContext(ctx, "tx-delete-artifact-delete"))
heww
approved these changes
Mar 10, 2022
Add transaction for artifact deletion, given API has the transaction when to call artifact controller but other object may not, for example jobservice job. Here, force add the tx to ensure all the things can be rolled back. Signed-off-by: Wang Yan <wangyan@vmware.com>
wy65701436
force-pushed
the
add-tx-art-del
branch
from
b0f394b
to
00fc86f
Compare
sluetze
pushed a commit
to sluetze/harbor
that referenced
this pull request
Oct 29, 2022
Add transaction for artifact deletion, given API has the transaction when to call artifact controller but other object may not, for example jobservice job. Here, force add the tx to ensure all the things can be rolled back. Signed-off-by: Wang Yan <wangyan@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add transaction for artifact deletion, given API has the transaction when to call artifact controller but other object may not, for example jobservice job.
Here, force add the tx to ensure all the things can be rolled back.
Signed-off-by: Wang Yan wangyan@vmware.com