Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cosign signature icon #16533

Merged
merged 1 commit into from
Mar 17, 2022
Merged

add cosign signature icon #16533

merged 1 commit into from
Mar 17, 2022

Conversation

wy65701436
Copy link
Contributor

Return icon message for UI to render

Signed-off-by: Wang Yan wangyan@vmware.com

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #16533 (3c8fb5e) into main (846dc94) will decrease coverage by 0.04%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16533      +/-   ##
==========================================
- Coverage   67.39%   67.35%   -0.05%     
==========================================
  Files         951      951              
  Lines       78909    78920      +11     
  Branches     2321     2321              
==========================================
- Hits        53183    53156      -27     
- Misses      22167    22203      +36     
- Partials     3559     3561       +2     
Flag Coverage Δ
unittests 67.35% <57.14%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pkg/accessory/model/accessory.go 88.23% <ø> (ø)
src/server/v2.0/handler/model/accessory.go 0.00% <0.00%> (ø)
src/controller/icon/controller.go 61.70% <28.57%> (-3.42%) ⬇️
src/pkg/accessory/manager.go 83.05% <100.00%> (+1.91%) ⬆️
src/controller/event/handler/auditlog/auditlog.go 8.69% <0.00%> (-52.18%) ⬇️
src/lib/cache/util.go 73.68% <0.00%> (-15.79%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 52.38% <0.00%> (-9.53%) ⬇️
src/controller/event/topic.go 1.80% <0.00%> (-9.01%) ⬇️
src/common/utils/passports.go 84.61% <0.00%> (-5.13%) ⬇️
...t/artifact-list-page/artifact-list-page.service.ts 26.58% <0.00%> (-0.35%) ⬇️
... and 1 more

Return icon message for UI to render

Signed-off-by: Wang Yan <wangyan@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 7cb5c34 into goharbor:main Mar 17, 2022
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
Return icon message for UI to render

Signed-off-by: Wang Yan <wangyan@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants