Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade UI dependencies #16586

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Upgrade UI dependencies #16586

merged 1 commit into from
Mar 25, 2022

Conversation

AllForNothing
Copy link
Contributor

Signed-off-by: AllForNothing sshijun@vmware.com

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #16586 (e8ad371) into main (d2a62cf) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16586      +/-   ##
==========================================
- Coverage   67.33%   67.32%   -0.02%     
==========================================
  Files         953      953              
  Lines       79013    79013              
  Branches     2331     2331              
==========================================
- Hits        53207    53194      -13     
- Misses      22232    22246      +14     
+ Partials     3574     3573       -1     
Flag Coverage Δ
unittests 67.32% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../portal/src/app/dev-center/dev-center.component.ts 40.62% <ø> (ø)
src/controller/event/handler/auditlog/auditlog.go 8.69% <0.00%> (-47.83%) ⬇️
src/core/api/internal.go 40.00% <0.00%> (-13.34%) ⬇️
src/controller/event/topic.go 1.80% <0.00%> (-7.21%) ⬇️
src/jobservice/sync/schedule.go 59.45% <0.00%> (+8.10%) ⬆️

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing merged commit 29eaaf1 into goharbor:main Mar 25, 2022
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants