Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrations: correct project metadata public value #16597

Merged

Conversation

chlins
Copy link
Member

@chlins chlins commented Mar 28, 2022

Signed-off-by: chlins chenyuzh@vmware.com

Signed-off-by: chlins <chenyuzh@vmware.com>
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #16597 (f7d1047) into main (a0fcb91) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16597      +/-   ##
==========================================
- Coverage   67.34%   67.33%   -0.01%     
==========================================
  Files         953      953              
  Lines       79013    79013              
  Branches     2331     2331              
==========================================
- Hits        53209    53203       -6     
- Misses      22228    22237       +9     
+ Partials     3576     3573       -3     
Flag Coverage Δ
unittests 67.33% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/rbac/system/namespace.go 33.33% <0.00%> (-11.12%) ⬇️
...tegration/tag-retention/tag-retention.component.ts 30.43% <0.00%> (-5.22%) ⬇️
src/common/utils/passports.go 84.61% <0.00%> (-5.13%) ⬇️
src/controller/event/handler/auditlog/auditlog.go 56.52% <0.00%> (-4.35%) ⬇️
src/controller/event/topic.go 9.00% <0.00%> (-1.81%) ⬇️
src/lib/cache/util.go 89.47% <0.00%> (+15.78%) ⬆️
...g-retention-tasks/tag-retention-tasks.component.ts 85.71% <0.00%> (+25.71%) ⬆️

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit fe3c0bd into goharbor:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants