Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new template file for PRs #16645

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

OrlinVasilev
Copy link
Member

Current file is not correct and it's not applied

Here is example how it will look:
OrlinVasilev/release#11

Signed-off-by: OrlinVasilev ovasilev@vmware.com

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #16645 (01cc046) into main (a5b5e21) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16645      +/-   ##
==========================================
- Coverage   67.31%   67.29%   -0.03%     
==========================================
  Files         953      953              
  Lines       79028    79044      +16     
  Branches     2331     2331              
==========================================
- Hits        53198    53189       -9     
- Misses      22259    22278      +19     
- Partials     3571     3577       +6     
Flag Coverage Δ
unittests 67.29% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g-retention-tasks/tag-retention-tasks.component.ts 60.00% <0.00%> (-25.72%) ⬇️
...ortal/src/app/shared/pipes/harbor-datetime.pipe.ts 50.00% <0.00%> (-25.00%) ⬇️
src/lib/cache/util.go 73.68% <0.00%> (-15.79%) ⬇️
src/server/middleware/util/util.go 91.66% <0.00%> (-8.34%) ⬇️
.../portal/src/app/shared/services/project.service.ts 2.50% <0.00%> (-5.00%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 57.14% <0.00%> (-4.77%) ⬇️
src/server/middleware/contenttrust/cosign.go 72.72% <0.00%> (-3.94%) ⬇️
src/server/middleware/contenttrust/notary.go 69.44% <0.00%> (-3.29%) ⬇️
src/server/middleware/vulnerable/vulnerable.go 93.84% <0.00%> (-2.93%) ⬇️
...count-settings/account-settings-modal.component.ts 75.47% <0.00%> (-0.33%) ⬇️
... and 2 more

.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
Copy link

@a-mccarthy a-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OrlinVasilev Thanks for updating this! just a few some comments. Overall i think its really awesome

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
Current file is not correct and it's not applied

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>
Copy link

@a-mccarthy a-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks orrlin!

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OrlinVasilev OrlinVasilev merged commit 95768b6 into goharbor:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants