Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear some UI building warnings #16684

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Conversation

AllForNothing
Copy link
Contributor

  1. Upgrade swagger UI and add some packages to the "allowedCommonJsDependencies" array in angular.json file
    Signed-off-by: AllForNothing sshijun@vmware.com

Signed-off-by: AllForNothing <sshijun@vmware.com>
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #16684 (c17429a) into main (185d38c) will decrease coverage by 4.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16684      +/-   ##
==========================================
- Coverage   71.66%   67.34%   -4.32%     
==========================================
  Files         723      953     +230     
  Lines       66887    79044   +12157     
  Branches        0     2331    +2331     
==========================================
+ Hits        47932    53235    +5303     
- Misses      15665    22230    +6565     
- Partials     3290     3579     +289     
Flag Coverage Δ
unittests 67.34% <ø> (-4.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../project/member/add-member/add-member.component.ts 26.31% <0.00%> (ø)
...al/src/app/base/left-side-nav/user/user.service.ts 20.93% <0.00%> (ø)
...e/project/robot-account/robot-account.component.ts 34.24% <0.00%> (ø)
...omponents/cron-schedule/cron-schedule.component.ts 27.45% <0.00%> (ø)
...rt-versions-detail/helm-chart-version.component.ts 28.22% <0.00%> (ø)
...-confirmation-dialog/confirmation-batch-message.ts 57.14% <0.00%> (ø)
.../base/left-side-nav/projects/projects.component.ts 32.65% <0.00%> (ø)
...group/add-group-modal/add-group-modal.component.ts 43.47% <0.00%> (ø)
src/portal/src/polyfills.ts 100.00% <0.00%> (ø)
...ared/components/push-image/push-image.component.ts 36.36% <0.00%> (ø)
... and 223 more

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit 1cc0c44 into goharbor:main Apr 12, 2022
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing deleted the warning branch January 6, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants