Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Replace stale.yaml with stale GH Actions #16699

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

OrlinVasilev
Copy link
Member

@OrlinVasilev OrlinVasilev commented Apr 13, 2022

stale.yaml not supported anymore!
https://github.com/marketplace/actions/close-stale-issues

Signed-off-by: OrlinVasilev ovasilev@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #16698

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

stale.yaml not supported anymore!
https://github.com/marketplace/actions/close-stale-issues

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>
@OrlinVasilev OrlinVasilev added the release-note/infra Infra related changes e.g. release, test, ship etc... label Apr 13, 2022
@OrlinVasilev OrlinVasilev requested a review from a team as a code owner April 13, 2022 12:35
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #16699 (4f34ef5) into main (527508f) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16699      +/-   ##
==========================================
+ Coverage   67.30%   67.32%   +0.02%     
==========================================
  Files         953      953              
  Lines       79044    79044              
  Branches     2331     2331              
==========================================
+ Hits        53197    53217      +20     
+ Misses      22268    22249      -19     
+ Partials     3579     3578       -1     
Flag Coverage Δ
unittests 67.32% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/portal/src/app/shared/units/shared.utils.ts 33.76% <0.00%> (-2.60%) ⬇️
src/jobservice/worker/cworker/c_worker.go 66.50% <0.00%> (-1.92%) ⬇️
...tegration/tag-retention/tag-retention.component.ts 35.65% <0.00%> (+5.21%) ⬆️
src/lib/cache/helper.go 82.60% <0.00%> (+8.69%) ⬆️
src/common/rbac/system/namespace.go 44.44% <0.00%> (+11.11%) ⬆️
src/core/api/internal.go 53.33% <0.00%> (+13.33%) ⬆️
src/lib/cache/util.go 89.47% <0.00%> (+15.78%) ⬆️
...ortal/src/app/shared/pipes/harbor-datetime.pipe.ts 75.00% <0.00%> (+25.00%) ⬆️

Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need that!

@OrlinVasilev
Copy link
Member Author

@tianon @qnetter @wy65701436 please check as well!

@Vad1mo Vad1mo assigned Vad1mo and unassigned Vad1mo Apr 20, 2022
@Vad1mo Vad1mo requested a review from a team April 20, 2022 19:55
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OrlinVasilev OrlinVasilev merged commit d68b781 into goharbor:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stale bot not supported anymore needs to be replaced with GH action
3 participants