Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open more info page test case #16708

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Apr 18, 2022

Add test case that open more info page to ensure correct functionality.

Signed-off-by: Yang Jiao jiaoya@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Add test case that open more info page to ensure correct functionality.

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 added area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... labels Apr 18, 2022
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner April 18, 2022 03:32
@YangJiao0817 YangJiao0817 removed the request for review from a team April 18, 2022 03:32
@YangJiao0817 YangJiao0817 self-assigned this Apr 18, 2022
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #16708 (f92a25f) into main (40191e0) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16708   +/-   ##
=======================================
  Coverage   67.33%   67.34%           
=======================================
  Files         953      953           
  Lines       79045    79045           
  Branches     2332     2332           
=======================================
+ Hits        53224    53231    +7     
+ Misses      22243    22236    -7     
  Partials     3578     3578           
Flag Coverage Δ
unittests 67.34% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/vulnerability/vulnerability-config.component.ts 61.90% <0.00%> (+4.76%) ⬆️
src/common/rbac/system/namespace.go 44.44% <0.00%> (+11.11%) ⬆️

Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 18c9791 into goharbor:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants