Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some css style issues #16709

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Apr 18, 2022

Fix #16683

  1. Fix some CSS style issues
    Signed-off-by: AllForNothing sshijun@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing requested a review from a team as a code owner April 18, 2022 04:58
@AllForNothing AllForNothing added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Apr 18, 2022
@AllForNothing AllForNothing self-assigned this Apr 18, 2022
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #16709 (9aae8aa) into main (40191e0) will decrease coverage by 0.00%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16709      +/-   ##
==========================================
- Coverage   67.33%   67.33%   -0.01%     
==========================================
  Files         953      953              
  Lines       79045    79056      +11     
  Branches     2332     2332              
==========================================
+ Hits        53224    53230       +6     
- Misses      22243    22247       +4     
- Partials     3578     3579       +1     
Flag Coverage Δ
unittests 67.33% <18.18%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...te-edit-endpoint/create-edit-endpoint.component.ts 37.07% <18.18%> (-1.08%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 52.38% <0.00%> (-4.77%) ⬇️
src/common/rbac/system/namespace.go 44.44% <0.00%> (+11.11%) ⬆️
...g-retention-tasks/tag-retention-tasks.component.ts 85.71% <0.00%> (+25.71%) ⬆️

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit 23b22c8 into goharbor:main Apr 26, 2022
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing deleted the css-issues branch January 6, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some UI style issues
4 participants