Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for Enable Deployment Security Policy replication #16737

Merged

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Apr 25, 2022

Add test cases for these three different scenarios to ensure that Replication functions correctly after Deployment Security Policy is enabled.

Signed-off-by: Yang Jiao jiaoya@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #16714

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Add test cases for these three different scenarios to ensure that Replication functions correctly after Deployment Security Policy is enabled

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 added area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... labels Apr 25, 2022
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner April 25, 2022 06:29
@YangJiao0817 YangJiao0817 self-assigned this Apr 25, 2022
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #16737 (1207982) into main (5eb0c08) will increase coverage by 4.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16737      +/-   ##
==========================================
+ Coverage   67.30%   71.67%   +4.36%     
==========================================
  Files         953      723     -230     
  Lines       79047    66890   -12157     
  Branches     2332        0    -2332     
==========================================
- Hits        53205    47944    -5261     
+ Misses      22264    15658    -6606     
+ Partials     3578     3288     -290     
Flag Coverage Δ
unittests 71.67% <ø> (+4.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rogation-services/vulnerability/scanAll.service.ts
...ect/webhook/last-trigger/last-trigger.component.ts
...es/vulnerability/vulnerability-config.component.ts
...rtal/src/app/shared/services/RequestQueryParams.ts
...tal/src/app/shared/services/system-info.service.ts
.../chart-detail/chart-detail-dependency.component.ts
.../projects/statictics/statistics-panel.component.ts
...-chart/helm-chart-detail/chart-detail.component.ts
...src/app/shared/components/label/label.component.ts
...p/shared/components/operation/operation.service.ts
... and 225 more

@YangJiao0817 YangJiao0817 merged commit 0c8754f into goharbor:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test case for Enable Replication of Deployment Security Policy
3 participants