Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imgpkg copy test case #16760

Merged
merged 1 commit into from
May 10, 2022

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Apr 27, 2022

Add this test case to make sure imgpkg copy to Harbor works.

Signed-off-by: Yang Jiao jiaoya@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #16758

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Add this test case to make sure imgpkg copy to Harbor works.

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 added area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... labels Apr 27, 2022
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner April 27, 2022 06:30
@YangJiao0817 YangJiao0817 self-assigned this Apr 27, 2022
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #16760 (18b9856) into main (bb53493) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16760      +/-   ##
==========================================
- Coverage   67.33%   67.31%   -0.03%     
==========================================
  Files         956      956              
  Lines       79203    79203              
  Branches     2332     2332              
==========================================
- Hits        53331    53315      -16     
- Misses      22270    22288      +18     
+ Partials     3602     3600       -2     
Flag Coverage Δ
unittests 67.31% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/event/handler/auditlog/auditlog.go 8.69% <0.00%> (-47.83%) ⬇️
...g-retention-tasks/tag-retention-tasks.component.ts 60.00% <0.00%> (-25.72%) ⬇️
...ortal/src/app/shared/pipes/harbor-datetime.pipe.ts 50.00% <0.00%> (-25.00%) ⬇️
src/controller/event/topic.go 1.80% <0.00%> (-7.21%) ⬇️
src/common/utils/passports.go 84.61% <0.00%> (-5.13%) ⬇️
src/portal/src/app/shared/units/shared.utils.ts 33.76% <0.00%> (-2.60%) ⬇️
src/jobservice/runner/redis.go 67.82% <0.00%> (+5.21%) ⬆️
...tegration/tag-retention/tag-retention.component.ts 35.65% <0.00%> (+5.21%) ⬆️

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 2563cf1 into goharbor:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Imgpkg Copy test case
3 participants