Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(project): introduce cache manager for project (#16740) #16807

Merged
merged 1 commit into from
May 11, 2022

Conversation

chlins
Copy link
Member

@chlins chlins commented May 5, 2022

Implement cached manager for resource project and migrate project.Mgr
to pkg.ProjectMgr.

Signed-off-by: chlins chenyuzh@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #16740

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #16807 (0fd0c84) into main (6ca3665) will decrease coverage by 0.01%.
The diff coverage is 55.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16807      +/-   ##
==========================================
- Coverage   67.36%   67.34%   -0.02%     
==========================================
  Files         960      961       +1     
  Lines       79429    79499      +70     
  Branches     2343     2343              
==========================================
+ Hits        53505    53540      +35     
- Misses      22312    22327      +15     
- Partials     3612     3632      +20     
Flag Coverage Δ
unittests 67.34% <55.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/member/controller.go 0.00% <0.00%> (ø)
src/controller/quota/driver/project/util.go 0.00% <0.00%> (ø)
src/pkg/cached/manager.go 100.00% <ø> (ø)
src/pkg/project/manager.go 4.34% <ø> (ø)
src/pkg/cached/project/redis/manager.go 46.96% <46.96%> (ø)
src/controller/project/controller.go 34.45% <100.00%> (ø)
src/controller/registry/controller.go 28.45% <100.00%> (ø)
src/controller/repository/controller.go 63.07% <100.00%> (ø)
src/controller/retention/controller.go 49.71% <100.00%> (ø)
src/controller/robot/controller.go 57.60% <100.00%> (ø)
... and 7 more

src/pkg/factory.go Outdated Show resolved Hide resolved
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Implement cached manager for resource project and migrate project.Mgr
to pkg.ProjectMgr.

Signed-off-by: chlins <chenyuzh@vmware.com>
@chlins chlins force-pushed the feat/cache-layer-for-project branch from 518c805 to 0fd0c84 Compare May 11, 2022 07:52
@chlins chlins merged commit f78047f into goharbor:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache layer for project.
3 participants