Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve css for tags column #16811

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented May 6, 2022

Fixes #16809

  1. Improve CSS for tags column to enable resizing
    Signed-off-by: AllForNothing sshijun@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing requested a review from a team as a code owner May 6, 2022 02:56
@AllForNothing AllForNothing added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label May 6, 2022
@AllForNothing AllForNothing self-assigned this May 6, 2022
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #16811 (f2618d1) into main (584245e) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16811      +/-   ##
==========================================
+ Coverage   67.32%   67.35%   +0.02%     
==========================================
  Files         956      956              
  Lines       79275    79276       +1     
  Branches     2342     2343       +1     
==========================================
+ Hits        53375    53396      +21     
+ Misses      22295    22275      -20     
  Partials     3605     3605              
Flag Coverage Δ
unittests 67.35% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/artifact-list-tab/artifact-list-tab.component.ts 26.85% <0.00%> (-0.05%) ⬇️
src/common/rbac/system/namespace.go 33.33% <0.00%> (-11.12%) ⬇️
src/common/utils/passports.go 84.61% <0.00%> (-5.13%) ⬇️
src/controller/event/topic.go 10.81% <0.00%> (+9.00%) ⬆️
src/lib/cache/util.go 89.47% <0.00%> (+15.78%) ⬆️
src/controller/event/handler/auditlog/auditlog.go 56.52% <0.00%> (+47.82%) ⬆️

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit 6ca3665 into goharbor:main May 10, 2022
@AllForNothing AllForNothing deleted the resize branch July 25, 2022 02:59
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizing columns width in repository table is wrong in v2.5.0
3 participants