Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CVE allowlist UI test case #16980

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Update CVE allowlist UI test case #16980

merged 1 commit into from
Jun 13, 2022

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Jun 10, 2022 •
edited
Loading

Because this PR #16941 migrates CVE allowlist from Configuration System
Settings page to Configuration Security page.

Signed-off-by: Yang Jiao jiaoya@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 added area/test automation/nightly-testing target/2.6.0 release-note/infra Infra related changes e.g. release, test, ship etc... labels Jun 10, 2022
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner June 10, 2022 08:47
@codecov
Copy link

codecov bot commented Jun 10, 2022 •
edited
Loading

Codecov Report

Merging #16980 (4d2d7fd) into main (4d2d7fd) will not change coverage.
The diff coverage is n/a.

❗ Current head 4d2d7fd differs from pull request most recent head 4ab434b. Consider uploading reports for the commit 4ab434b to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16980   +/-   ##
=======================================
  Coverage   67.17%   67.17%           
=======================================
  Files         979      979           
  Lines       81797    81797           
  Branches     2599     2599           
=======================================
  Hits        54944    54944           
  Misses      23101    23101           
  Partials     3752     3752
Flag Coverage Δ
unittests 67.17% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@YangJiao0817 YangJiao0817 self-assigned this Jun 10, 2022
AllForNothing
AllForNothing approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Update CVE allowlist UI test case
4ab434b 
Because this PR goharbor#16941 migrates CVE allowlist from Configuration System
Settings page to Configuration Security page.

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
chlins
chlins approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit a282985 into goharbor:main Jun 13, 2022
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
@YangJiao0817 @sluetze
Update CVE allowlist UI test case (goharbor#16980)
38763ce 
Because this PR goharbor#16941 migrates CVE allowlist from Configuration System
Settings page to Configuration Security page.

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllForNothing AllForNothing AllForNothing approved these changes

@chlins chlins chlins approved these changes

@wy65701436 wy65701436 Awaiting requested review from wy65701436

Assignees

@YangJiao0817 YangJiao0817

Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... target/2.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YangJiao0817 @AllForNothing @chlins