Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove style-lint package and upgrade @angular-devkit/build-angular #17009

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Jun 16, 2022

  1. Remove the style-lint package and upgrade @angular-devkit/build-angular

Signed-off-by: AllForNothing sshijun@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

…ackage

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing added the release-note/update Update or Fix label Jun 16, 2022
@AllForNothing AllForNothing requested a review from a team as a code owner June 16, 2022 03:38
@AllForNothing AllForNothing self-assigned this Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #17009 (79c73b4) into main (c2a9f5d) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17009      +/-   ##
==========================================
- Coverage   67.16%   67.09%   -0.07%     
==========================================
  Files         979      979              
  Lines       81776    81776              
  Branches     2604     2604              
==========================================
- Hits        54922    54871      -51     
- Misses      23103    23152      +49     
- Partials     3751     3753       +2     
Flag Coverage Δ
unittests 67.09% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/event/handler/auditlog/auditlog.go 8.69% <0.00%> (-52.18%) ⬇️
...g-retention-tasks/tag-retention-tasks.component.ts 61.11% <0.00%> (-25.00%) ⬇️
src/lib/cache/util.go 73.68% <0.00%> (-15.79%) ⬇️
src/lib/cache/helper.go 73.91% <0.00%> (-8.70%) ⬇️
src/controller/event/topic.go 1.80% <0.00%> (-7.21%) ⬇️
...tegration/tag-retention/tag-retention.component.ts 30.76% <0.00%> (-5.56%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 54.07% <0.00%> (-4.45%) ⬇️
src/jobservice/worker/cworker/c_worker.go 66.50% <0.00%> (-1.92%) ⬇️
...-job/gc-page/gc/gc-history/gc-history.component.ts 58.82% <0.00%> (+9.80%) ⬆️
src/common/rbac/system/namespace.go 44.44% <0.00%> (+11.11%) ⬆️

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit 6c02854 into goharbor:main Jun 20, 2022
@AllForNothing AllForNothing deleted the cves branch July 25, 2022 02:58
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
…oharbor#17009)

Remove style-lint package  and upgrade @angular-devkit/build-angular package

Signed-off-by: AllForNothing <sshijun@vmware.com>
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
…oharbor#17009)

Remove style-lint package  and upgrade @angular-devkit/build-angular package

Signed-off-by: AllForNothing <sshijun@vmware.com>
Signed-off-by: Stephan Hohn <stephan.hohn@tech11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants