Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stop purge audit log job #17033

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jun 20, 2022

fixes #17006

Signed-off-by: stonezdj stonezdj@gmail.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner June 20, 2022 02:58
@stonezdj stonezdj added the release-note/update Update or Fix label Jun 20, 2022
@stonezdj stonezdj changed the title Support stop purge audit log job [WIP]Support stop purge audit log job Jun 20, 2022
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #17033 (6a21e6c) into main (c7e1536) will increase coverage by 0.02%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17033      +/-   ##
==========================================
+ Coverage   67.16%   67.19%   +0.02%     
==========================================
  Files         979      979              
  Lines       81926    82047     +121     
  Branches     2604     2604              
==========================================
+ Hits        55027    55130     +103     
- Misses      23139    23156      +17     
- Partials     3760     3761       +1     
Flag Coverage Δ
unittests 67.19% <30.76%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/purge/controller.go 58.62% <0.00%> (-2.10%) ⬇️
src/server/v2.0/handler/purge.go 8.18% <0.00%> (-0.25%) ⬇️
src/jobservice/job/impl/purge/purge.go 64.70% <57.14%> (-1.21%) ⬇️
...tegration/tag-retention/tag-retention.component.ts 30.76% <0.00%> (-5.56%) ⬇️
...ortal/src/app/shared/pipes/harbor-datetime.pipe.ts 32.00% <0.00%> (-4.00%) ⬇️
src/server/v2.0/restapi/configure_harbor.go 6.32% <0.00%> (-0.04%) ⬇️
src/server/v2.0/restapi/embedded_spec.go 100.00% <0.00%> (ø)
src/pkg/task/dao/execution.go 67.48% <0.00%> (+0.40%) ⬆️
src/common/utils/passports.go 89.74% <0.00%> (+5.12%) ⬆️
...es/vulnerability/vulnerability-config.component.ts 62.96% <0.00%> (+8.88%) ⬆️

@stonezdj stonezdj force-pushed the 22jun20_stop_purge branch 3 times, most recently from 135490a to f326efd Compare June 20, 2022 13:53
  fixes goharbor#17006

Signed-off-by: stonezdj <stonezdj@gmail.com>
@stonezdj stonezdj changed the title [WIP]Support stop purge audit log job Support stop purge audit log job Jun 21, 2022
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit c639257 into goharbor:main Jun 28, 2022
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
fixes goharbor#17006

Signed-off-by: stonezdj <stonezdj@gmail.com>
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
fixes goharbor#17006

Signed-off-by: stonezdj <stonezdj@gmail.com>
Signed-off-by: Stephan Hohn <stephan.hohn@tech11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support stop log rotation execution
3 participants