Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pipenv to 2022.1.8 #17093

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Jun 28, 2022

Signed-off-by: Yang Jiao jiaoya@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 added the release-note/update Update or Fix label Jun 28, 2022
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner June 28, 2022 10:10
@YangJiao0817 YangJiao0817 self-assigned this Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #17093 (1a0f0f0) into main (889407a) will decrease coverage by 4.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17093      +/-   ##
==========================================
- Coverage   71.47%   67.09%   -4.38%     
==========================================
  Files         745      979     +234     
  Lines       69279    82230   +12951     
  Branches        0     2630    +2630     
==========================================
+ Hits        49515    55170    +5655     
- Misses      16301    23280    +6979     
- Partials     3463     3780     +317     
Flag Coverage Δ
unittests 67.09% <ø> (-4.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../app/base/left-side-nav/replication/replication.ts 100.00% <0.00%> (ø)
...ation-services/interrogation-services.component.ts 100.00% <0.00%> (ø)
.../app/shared/directives/date-validator.directive.ts 53.33% <0.00%> (ø)
...-setup-modal/distribution-setup-modal.component.ts 36.21% <0.00%> (ø)
...ft-side-nav/distribution/distribution-interface.ts 100.00% <0.00%> (ø)
...omponents/global-search/global-search.component.ts 72.50% <0.00%> (ø)
...tegration/tag-retention/tag-retention.component.ts 36.32% <0.00%> (ø)
...tal/src/app/oidc-onboard/oidc-onboard.component.ts 60.00% <0.00%> (ø)
...nents/third-party/ngx-window-token/window-token.ts 100.00% <0.00%> (ø)
.../components/global-search/global-search.service.ts 85.71% <0.00%> (ø)
... and 227 more

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 77d2810 into goharbor:main Jun 28, 2022
sluetze pushed a commit to sluetze/harbor that referenced this pull request Oct 29, 2022
Signed-off-by: Yang Jiao <jiaoya@vmware.com>
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
Signed-off-by: Yang Jiao <jiaoya@vmware.com>
Signed-off-by: Stephan Hohn <stephan.hohn@tech11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants