Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScanAll should only log an error when an error occurs #20087

Merged
merged 9 commits into from
Mar 27, 2024
Merged

ScanAll should only log an error when an error occurs #20087

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
18a53cf
ScanAll should only log an error when an error occurs
twhiteman Mar 1, 2024
54afedc
Merge branch 'main' into tweak_scanall_log_error
twhiteman Mar 7, 2024
121d1c4
Merge branch 'main' into tweak_scanall_log_error
twhiteman Mar 11, 2024
275939a
Merge branch 'main' into tweak_scanall_log_error
wy65701436 Mar 12, 2024
5ab45fc
Merge branch 'main' into tweak_scanall_log_error
twhiteman Mar 12, 2024
5231fc4
Merge branch 'main' into tweak_scanall_log_error
twhiteman Mar 15, 2024
fa86a86
Merge branch 'main' into tweak_scanall_log_error
wy65701436 Mar 25, 2024
10e3567
Merge branch 'main' into tweak_scanall_log_error
wy65701436 Mar 26, 2024
e2f9db9
Merge branch 'main' into tweak_scanall_log_error
wy65701436 Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/controller/scan/base_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,9 @@ func (bc *basicController) ScanAll(ctx context.Context, trigger string, async bo
}

err = bc.startScanAll(ctx, executionID)
log.Errorf("failed to start scan all, executionID=%d, error: %v", executionID, err)
if err != nil {
log.Errorf("failed to start scan all, executionID=%d, error: %v", executionID, err)
}
}(bc.makeCtx())
} else {
if err := bc.startScanAll(ctx, executionID); err != nil {
Expand Down
Loading