Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick ]Release 2.11.0 cp 20803 #20814

Merged

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Aug 6, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #20756

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

This API supports listing all artifacts belonging to a specified project. It also allows fetching the latest artifact
in each repositry, with the option to filter by either media_type or artifact_type.

Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 26.71233% with 107 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-2.11.0@14f98c0). Learn more about missing BASE report.

Files Patch % Lines
src/server/v2.0/handler/project.go 0.00% 70 Missing ⚠️
src/pkg/artifact/dao/dao.go 59.52% 12 Missing and 5 partials ⚠️
src/server/v2.0/handler/artifact.go 0.00% 7 Missing ⚠️
src/pkg/artifact/manager.go 53.84% 4 Missing and 2 partials ⚠️
src/controller/artifact/controller.go 70.00% 2 Missing and 1 partial ⚠️
src/pkg/cached/artifact/redis/manager.go 0.00% 2 Missing ⚠️
src/server/v2.0/handler/model/artifact.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20814   +/-   ##
=================================================
  Coverage                  ?   66.28%           
=================================================
  Files                     ?     1045           
  Lines                     ?   113973           
  Branches                  ?     2845           
=================================================
  Hits                      ?    75545           
  Misses                    ?    34307           
  Partials                  ?     4121           
Flag Coverage Δ
unittests 66.28% <26.71%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/artifact/model.go 40.00% <ø> (ø)
src/pkg/cached/artifact/redis/manager.go 60.65% <0.00%> (ø)
src/server/v2.0/handler/model/artifact.go 0.00% <0.00%> (ø)
src/controller/artifact/controller.go 62.15% <70.00%> (ø)
src/pkg/artifact/manager.go 64.13% <53.84%> (ø)
src/server/v2.0/handler/artifact.go 8.66% <0.00%> (ø)
src/pkg/artifact/dao/dao.go 57.63% <59.52%> (ø)
src/server/v2.0/handler/project.go 5.23% <0.00%> (ø)

Signed-off-by: wang yan <wangyan@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit dfcba09 into goharbor:release-2.11.0 Aug 7, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants