UI Changes for Configuring Proxy-Cache Speed Limit #20862

kunal-511 · 2024-08-20T13:48:34Z

Thank you for contributing to Harbor!

proxy-cache bandwidth limit UI change

Comprehensive Summary of your change

This pull request addresses the UI changes required for configuring the proxy-cache speed limit, as outlined in Issue #20589. The changes include the addition of a bandwidth field for setting the speed limit in both the proxy-cache creation page and the project configuration page

Issue being fixed

Fixes #20811

Please indicate you've done the following:

Well Written Title and Summary of the PR
Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
Accepted the DCO. Commits without the DCO will delay acceptance.
Made sure tests are passing and test coverage is added if needed.
Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Vad1mo · 2024-08-20T16:39:49Z

src/portal/src/i18n/lang/en-us-lang.json

@@ -246,6 +246,7 @@
        "TOGGLED_SUCCESS": "Toggled project successfully.",
        "FAILED_TO_DELETE_PROJECT": "Project contains repositories or replication rules or helm-charts cannot be deleted.",
        "INLINE_HELP_PUBLIC": "When a project is set to public, anyone has read permission to the repositories under this project, and the user does not need to run \"docker login\" before pulling images under this project.",
+        "PROXY_CACHE_BANDWIDTH":"Set the maximum network bandwidth to pull image from upstream for proxy-cache. For unlimited bandwidth, please enter -1. ",


this string needs to be added to all language files. (Put it in the english version), for later translation.

Its than easier to pick it up by others and translate

Added this line to all the language files

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

codecov · 2024-08-21T06:48:22Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.02%. Comparing base (c8c11b4) to head (269e527).
Report is 285 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #20862       +/-   ##
===========================================
+ Coverage   45.36%   69.02%   +23.65%     
===========================================
  Files         244      800      +556     
  Lines       13333   100469    +87136     
  Branches     2719        0     -2719     
===========================================
+ Hits         6049    69352    +63303     
- Misses       6983    27320    +20337     
- Partials      301     3797     +3496

Flag	Coverage Δ
unittests	`69.02% <ø> (+23.65%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1040 files with indirect coverage changes

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

stonezdj · 2024-08-30T06:51:57Z

Verified the UI, the payload is wrong:

{"project_name":"dockerhub5","metadata":{"public":"true"},"storage_limit":-1,"registry_id":1}

It should be in this format

{"project_name":"dockerhub5","metadata":{"public":"true", "storage_limit":-1},"registry_id":1}

stonezdj · 2024-08-30T07:02:00Z

The color in the warning message is different from the existing color.

stonezdj · 2024-09-02T05:48:34Z

@kunal-511 could please refer to this PR stonezdj@e39f73e to update your code.

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

kunal-511 · 2024-09-02T08:20:29Z

@stonezdj Updated my PR

chlins · 2024-09-03T03:54:23Z

@kunal-511 Please resolve the code conflicts.

kunal-511 · 2024-09-03T04:23:52Z

@kunal-511 Please resolve the code conflicts.

Resolved the code conflicts

kunal-511 · 2024-09-03T04:27:09Z

@kunal-511 could please refer to this PR stonezdj@e39f73e to update your code.

need to update other language json files ??

stonezdj · 2024-09-03T09:29:39Z

@stonezdj Updated my PR

Please update the language json file to add this line.

        "BANDWIDTH": "Bandwidth",
        "SPEED_LIMIT_TIP": "Please enter -1 or an integer  greater than 0. ",

kunal-511 · 2024-09-03T09:38:35Z

@stonezdj Updated my PR

Please update the language json file to add this line.
        "BANDWIDTH": "Bandwidth",
        "SPEED_LIMIT_TIP": "Please enter -1 or an integer  greater than 0. ",

Need to add this to all language json files?

stonezdj · 2024-09-04T02:39:51Z

@stonezdj Updated my PR

Please update the language json file to add this line.
        "BANDWIDTH": "Bandwidth",
        "SPEED_LIMIT_TIP": "Please enter -1 or an integer  greater than 0. ",
Need to add this to all language json files?

Yes

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

kunal-511 · 2024-09-04T15:49:09Z

@stonezdj Updated my PR

Please update the language json file to add this line.
        "BANDWIDTH": "Bandwidth",
        "SPEED_LIMIT_TIP": "Please enter -1 or an integer  greater than 0. ",
Need to add this to all language json files?
Yes

Added

stonezdj · 2024-09-09T06:05:09Z

...c/app/base/project/project-config/project-policy-config/project-policy-config.component.scss

@@ -1,6 +1,9 @@
 #severity-blk div {
  display: inline-block;
 }
+.mr-10 {


The current UI change is only limit to create project, why change the CSS of the project policy config?

The current UI change is only limit to create project, why change the CSS of the project policy config?

It was initially told by @zyyw that we need to make changes to both the create project and also to the project policy-config page

stonezdj · 2024-09-09T06:10:04Z

Please squash all commit into one @kunal-511

kunal-511 · 2024-09-09T06:29:39Z

Please squash all commit into one @kunal-511

Yes I will do this

xuelichao · 2024-09-10T05:45:41Z

src/portal/src/app/base/left-side-nav/projects/create-project/create-project.component.ts

+            (value <= 0 && value !== -1)
+        ) {
+            this.bandwidthError =
+                'Please enter -1 or an integer  greater than 0.';


Remove extra white space between word 'integer' and 'greater'

xuelichao · 2024-09-10T05:49:40Z

src/portal/src/i18n/lang/zh-tw-lang.json

    "OF": "共計",
    "COUNT_QUOTA": "數量配額",
    "STORAGE_QUOTA": "儲存配額限制",
    "COUNT_QUOTA_TIP": "請輸入介於 '1' 和 '100,000,000' 之間的整數，'-1' 表示無限制。",
    "STORAGE_QUOTA_TIP": "儲存配額上限只接受整數，上限為 '1024TB'。輸入 '-1' 表示無限配額。",
    "QUOTA_UNLIMIT_TIP": "專案所能使用的最大邏輯空間。輸入 '-1' 表示無限制配額。",
+    "BANDWIDTH": "Bandwidth",
+        "SPEED_LIMIT_TIP": "Please enter -1 or an integer  greater than 0. ",


remove the extra indent

xuelichao · 2024-09-10T05:58:12Z

...c/app/base/project/project-config/project-policy-config/project-policy-config.component.html

+                >
+                <div class="flex">
+                    <input
+                        class="clr-input width-164 mr-10"


why does the [(ngModel)] not configured for the input element?

xuelichao · 2024-09-10T05:59:18Z

...c/app/base/project/project-config/project-policy-config/project-policy-config.component.html

+                    <div class="clr-select-wrapper mr-10">
+                        <select name="" id="">
+                            <option value="kbps" selected>kbps</option>
+                            <option value="Mbps">Mbps</option>


[(ngModel)] is not configured for select. why?

stonezdj · 2024-09-18T06:56:37Z

@kunal-511 could you please fix the review comment issue before the FC date(Sept 22)?

kunal-511 · 2024-09-19T12:49:50Z

@stonezdj I have created a new PR with single commit and also addressed above issues. Please have a look #20946

kunal-511 added 2 commits August 20, 2024 19:17

Added the option of bandwidth from UI side under the new project

167c7cb

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Added ProxyCache Bandwidth input field in project config

920683d

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

kunal-511 changed the title ~~proxy-cache bandwidth limit UI change~~ UI Changes for Configuring Proxy-Cache Speed Limit Aug 20, 2024

kunal-511 marked this pull request as ready for review August 20, 2024 15:18

kunal-511 requested a review from a team as a code owner August 20, 2024 15:18

github-actions bot assigned MinerYang, stonezdj and Vad1mo Aug 20, 2024

Vad1mo added the release-note/update Update or Fix label Aug 20, 2024

Vad1mo requested changes Aug 20, 2024

View reviewed changes

Added PROXY_CACHE_BANDWIDTH to all language files

bd93228

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

kunal-511 requested a review from Vad1mo August 20, 2024 17:42

kunal-511 added 2 commits August 21, 2024 12:25

Fixed the logic ProxyCache bandwidth display and change the styling also

448d165

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Added check for the bandwidth input field

8f582d6

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

MinerYang added the area/ui label Aug 26, 2024

MinerYang assigned zyyw Aug 26, 2024

Updated the UI of badnwidth moadal

6a6352d

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Lint fix applied

92106a7

Updated all lang json files

269e527

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

stonezdj reviewed Sep 9, 2024

View reviewed changes

xuelichao reviewed Sep 10, 2024

View reviewed changes

kunal-511 closed this Oct 2, 2024

kunal-511 deleted the feat-#20811 branch October 2, 2024 08:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI Changes for Configuring Proxy-Cache Speed Limit #20862

UI Changes for Configuring Proxy-Cache Speed Limit #20862

kunal-511 commented Aug 20, 2024 •

edited by Vad1mo

Loading

Vad1mo Aug 20, 2024

kunal-511 Aug 20, 2024

codecov bot commented Aug 21, 2024 •

edited

Loading

stonezdj commented Aug 30, 2024 •

edited

Loading

stonezdj commented Aug 30, 2024

stonezdj commented Sep 2, 2024

kunal-511 commented Sep 2, 2024

chlins commented Sep 3, 2024

kunal-511 commented Sep 3, 2024

kunal-511 commented Sep 3, 2024

stonezdj commented Sep 3, 2024

kunal-511 commented Sep 3, 2024

stonezdj commented Sep 4, 2024

kunal-511 commented Sep 4, 2024

stonezdj Sep 9, 2024

kunal-511 Sep 9, 2024

stonezdj commented Sep 9, 2024

kunal-511 commented Sep 9, 2024

xuelichao Sep 10, 2024

xuelichao Sep 10, 2024

xuelichao Sep 10, 2024

xuelichao Sep 10, 2024

stonezdj commented Sep 18, 2024

kunal-511 commented Sep 19, 2024

UI Changes for Configuring Proxy-Cache Speed Limit #20862

UI Changes for Configuring Proxy-Cache Speed Limit #20862

Conversation

kunal-511 commented Aug 20, 2024 • edited by Vad1mo Loading

Comprehensive Summary of your change

Issue being fixed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Aug 21, 2024 • edited Loading

Codecov Report

stonezdj commented Aug 30, 2024 • edited Loading

stonezdj commented Aug 30, 2024

stonezdj commented Sep 2, 2024

kunal-511 commented Sep 2, 2024

chlins commented Sep 3, 2024

kunal-511 commented Sep 3, 2024

kunal-511 commented Sep 3, 2024

stonezdj commented Sep 3, 2024

kunal-511 commented Sep 3, 2024

stonezdj commented Sep 4, 2024

kunal-511 commented Sep 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stonezdj commented Sep 9, 2024

kunal-511 commented Sep 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stonezdj commented Sep 18, 2024

kunal-511 commented Sep 19, 2024

kunal-511 commented Aug 20, 2024 •

edited by Vad1mo

Loading

codecov bot commented Aug 21, 2024 •

edited

Loading

stonezdj commented Aug 30, 2024 •

edited

Loading