Skip to content

Commit

Permalink
math/big: rename Int.ToFloat64 to Float64
Browse files Browse the repository at this point in the history
The "To" prefix was a relic of the first draft
that I failed to make consistent with the unprefixed
name used in the proposal. Fortunately iant spotted
it during the API audit.

Updates #56984
Updates #60560

Change-Id: Ifa6eeddf6dd5f0637c0568e383f9a4bef88b10f9
Reviewed-on: https://go-review.googlesource.com/c/go/+/500116
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Alan Donovan <adonovan@google.com>
  • Loading branch information
adonovan committed Jun 2, 2023
1 parent c71cbd5 commit fdbc66d
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion api/go1.21.txt
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ pkg maps, func Equal[$0 interface{ ~map[$2]$3 }, $1 interface{ ~map[$2]$3 }, $2
pkg maps, func EqualFunc[$0 interface{ ~map[$2]$3 }, $1 interface{ ~map[$2]$4 }, $2 comparable, $3 interface{}, $4 interface{}]($0, $1, func($3, $4) bool) bool #57436
pkg maps, func Keys[$0 interface{ ~map[$1]$2 }, $1 comparable, $2 interface{}]($0) []$1 #57436
pkg maps, func Values[$0 interface{ ~map[$1]$2 }, $1 comparable, $2 interface{}]($0) []$2 #57436
pkg math/big, method (*Int) ToFloat64() (float64, Accuracy) #56984
pkg math/big, method (*Int) Float64() (float64, Accuracy) #56984
pkg net/http, method (*ProtocolError) Is(error) bool #41198
pkg net/http, method (*ResponseController) EnableFullDuplex() error #57786
pkg net/http, var ErrSchemeMismatch error #44855
Expand Down
2 changes: 1 addition & 1 deletion doc/go1.21.html
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ <h3 id="minor_library_changes">Minor changes to the library</h3>
<dl id="math/big"><dt><a href="/pkg/math/big/">math/big</a></dt>
<dd>
<p><!-- https://go.dev/issue/56984, CL 453115 -->
The new <a href="/pkg/math/big/#Int.ToFloat64"><code>Int.ToFloat64</code></a>
The new <a href="/pkg/math/big/#Int.Float64"><code>Int.Float64</code></a>
method returns the nearest floating-point value to a
multi-precision integer, along with an indication of any
rounding that occurred.
Expand Down
4 changes: 2 additions & 2 deletions src/math/big/int.go
Original file line number Diff line number Diff line change
Expand Up @@ -450,9 +450,9 @@ func (x *Int) IsUint64() bool {
return !x.neg && len(x.abs) <= 64/_W
}

// ToFloat64 returns the float64 value nearest x,
// Float64 returns the float64 value nearest x,
// and an indication of any rounding that occurred.
func (x *Int) ToFloat64() (float64, Accuracy) {
func (x *Int) Float64() (float64, Accuracy) {
n := x.abs.bitLen() // NB: still uses slow crypto impl!
if n == 0 {
return 0.0, Exact
Expand Down
4 changes: 2 additions & 2 deletions src/math/big/int_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1952,7 +1952,7 @@ func TestNewIntAllocs(t *testing.T) {
}
}

func TestToFloat64(t *testing.T) {
func TestFloat64(t *testing.T) {
for _, test := range []struct {
istr string
f float64
Expand Down Expand Up @@ -1988,7 +1988,7 @@ func TestToFloat64(t *testing.T) {
}

// Test against expectation.
f, acc := i.ToFloat64()
f, acc := i.Float64()
if f != test.f || acc != test.acc {
t.Errorf("%s: got %f (%s); want %f (%s)", test.istr, f, acc, test.f, test.acc)
}
Expand Down

0 comments on commit fdbc66d

Please sign in to comment.