Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: freeze node version #4438

Merged
merged 1 commit into from
Dec 11, 2023
Merged

chore: freeze node version #4438

merged 1 commit into from
Dec 11, 2023

Conversation

NestorEncinas
Copy link
Contributor

@NestorEncinas NestorEncinas commented Dec 11, 2023 •
edited
Loading

Freeze node version used on ci builds to 18.17.0 since there are some breaking changes on 18.19.0

Supported PR commands:

Command Description
ok to test Re-run standard checks
extended check sonar SonarQube tests
extended test - backstop BackstopJS tests
E2E Cypress tests commands - TIGER
extended test - tiger-cypress - isolated <testName> Run isolated tests running against recorded Tiger backend.
extended test - tiger-cypress - record <testName> Create a new recording for isolated Tiger tests.
extended test - tiger-cypress - integrated <testName> Run integrated tests against live backend
E2E Cypress tests commands - BEAR
extended test - cypress - isolated <testName> Run isolated tests running against recorded Bear backend.
extended test - cypress - record <testName> Create a new recording for isolated Bear tests.
extended test - cypress - integrated <testName> Run integrated tests against live backend
Compatibility matrix test commands - TIGER Backend
extended test - matrix-test <AIO_version> Run integrated tests against AIO versions.

<testName> in cypress commands is used to filter specfiles. Example, to run record with BEAR backend

  • Against dashboard.spec.ts and drilling.spec.ts, execute command extended test - cypress - record dashboard,drilling
  • Against all specfiles, execute command extended test - cypress - record or extended test - cypress - record *

<AIO_version> in commands is used to start test with multiple AIO instances - each instance in triggered by one jenkins build

  • To run with master and stable, execute command extended test - matrix-test master,stable or extended test - matrix-test latest
  • To run with specific version,ex: 2.3.0 and 2.3.1, execute command extended test - matrix-test 2.3.0,2.3.1
  • In case <AIO_version> is empty, read versions from file compTigerVersions.txt of this repo

PR Checklist

  • commit messages adhere to the commit message guidelines
  • review was done by a Code owner if necessary (if you think it is not necessary, explain the reasoning in the description or in a comment)
  • check passes
  • extended test - backstop passes
  • extended test - tiger-cypress - record to record new mapping files (Tiger BE)
  • extended test - cypress - record to record new mapping files (Bear BE)
  • extended test - tiger-cypress - isolated passes
  • extended test - cypress - isolated passes
  • extended test - tiger-cypress - integrated passes
  • rush change was run if applicable

@gdgate
Copy link
Contributor

gdgate commented Dec 11, 2023

Build failed (check pipeline).

@gdgate
Copy link
Contributor

gdgate commented Dec 11, 2023

Build failed (check pipeline).

@gdgate
Copy link
Contributor

gdgate commented Dec 11, 2023

Build in pipeline check aborted.

@gdgate
Copy link
Contributor

gdgate commented Dec 11, 2023

Build succeeded (check pipeline).

@gdgate
Copy link
Contributor

gdgate commented Dec 11, 2023

Build succeeded (check pipeline).

@NestorEncinas NestorEncinas marked this pull request as ready for review December 11, 2023 11:22
@pbenes pbenes added the merge label Dec 11, 2023
@gdgate gdgate removed the merge label Dec 11, 2023
@gdgate
Copy link
Contributor

gdgate commented Dec 11, 2023

Build failed (gate pipeline).

@NestorEncinas
Copy link
Contributor Author

extended check sonar

@yenkins
Copy link

yenkins commented Dec 11, 2023

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ui-sdk-check-extended-sonar-PR4438

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@gdgate
Copy link
Contributor

gdgate commented Dec 11, 2023

Build succeeded (check-extended pipeline).

@yenkins
Copy link

yenkins commented Dec 11, 2023

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ui-sdk-gate-PR4438

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@gdgate gdgate removed the merge label Dec 11, 2023
@gdgate gdgate merged commit fd81070 into gooddata:master Dec 11, 2023
3 of 5 checks passed
@gdgate
Copy link
Contributor

gdgate commented Dec 11, 2023

Build succeeded (gate pipeline).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbenes pbenes pbenes approved these changes

@kandl kandl Awaiting requested review from kandl kandl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NestorEncinas @gdgate @yenkins @pbenes