Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

Optimize AFL for android #63

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Optimize AFL for android #63

wants to merge 3 commits into from

Conversation

JoeyJiao
Copy link
Contributor

  • Android enables fortify while I don't want AFL to find these issues, so add option to disable during compile
  • Android devices nowadays normally has cpu#0 as little cores while cpu#Max as big cores. so start afl on big cores by default.

Dor1s
Dor1s reviewed Jan 2, 2020
View reviewed changes
Copy link
Contributor

@Dor1s Dor1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this different from #59 ?

@JoeyJiao
Loop to next cpu core when set affinity failed
6434b83 
In most Android devices, cpu#0 is small core while cpu#Max is big core
@JoeyJiao
Add ndk support
f5731c7
@JoeyJiao
Copy link
Contributor Author

JoeyJiao commented Jan 3, 2020

is this different from #59 ?

rebase issue, updated with only new changes.
Thanks

@qlyoung qlyoung mentioned this pull request Jan 18, 2020
Open
@JoeyJiao
Copy link
Contributor Author

can you review the updated? @Dor1s

Dor1s
Dor1s reviewed Jan 28, 2020
View reviewed changes
afl-fuzz.c Outdated Show resolved Hide resolved
Dor1s
Dor1s reviewed Aug 5, 2020
View reviewed changes
Copy link
Contributor

@Dor1s Dor1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this version still has a lot of duplication. As I understand, the only Android-specific detail is the for-loop statement. In such case only that part should be under #ifdef, while the actual loop body can remain unconditional.

afl-fuzz.c
}
}
#else
for (i = cpu_core_count - cpu_start - 1; i > -1; i--) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i is unsigned, it cannot have a negative value and thus will always be > -1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dor1s Dor1s Dor1s left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeyJiao @Dor1s