Fix resource loading in GoogleSignInSwift with CocoaPods use_frameworks! #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a project using CocoaPods as its dependency manager added
use_frameworks!
in itsPodfile
, then we would fail to load resources from the bundle. This failure would lead to Google Sign-In image icon for the button to not load, for example.The reason for this failure was that we were previously using a class in the GoogleSignInSwift target to find the
Bundle
. While we would be able to find thisBundle
, it would not contain the resources included in theBundle
for GoogleSignIn.Fixes #194