Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the restorePreviousSignIn when completion is nil #301

Merged
merged 6 commits into from
May 4, 2023
Merged

Fix the restorePreviousSignIn when completion is nil #301

merged 6 commits into from
May 4, 2023

Commits on May 4, 2023

  1. Fix the restorePreviousSignIn when completion is nil

    @henryhl22321
    henryhl22321 committed May 4, 2023
    Configuration menu
    Copy the full SHA
    01bb8dd View commit details
    Browse the repository at this point in the history

  2. Add restorePreviousSignIn test case when completion is nil

    @henryhl22321
    henryhl22321 committed May 4, 2023
    Configuration menu
    Copy the full SHA
    7d35a42 View commit details
    Browse the repository at this point in the history

  3. Fixed the test problem from comments.

    @henryhl22321
    henryhl22321 committed May 4, 2023
    Configuration menu
    Copy the full SHA
    b6210ac View commit details
    Browse the repository at this point in the history

  4. Add the value to verify the _signIn.currentUser

    @henryhl22321
    henryhl22321 committed May 4, 2023
    Configuration menu
    Copy the full SHA
    bbb0cd4 View commit details
    Browse the repository at this point in the history

  5. Removed the mocked user data comparison, add TODO for using the real … 

    …GIDGoogleUser on GIDSignInTest
    @henryhl22321
    henryhl22321 committed May 4, 2023
    Configuration menu
    Copy the full SHA
    fa25c23 View commit details
    Browse the repository at this point in the history

  6. Removed the unused import

    @henryhl22321
    henryhl22321 committed May 4, 2023
    Configuration menu
    Copy the full SHA
    a8ce59e View commit details
    Browse the repository at this point in the history