[SystemUiController] Update SystemUiController to hoist dark theme #1275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the primary docs entrance to the system ui controller module slightly.
First, it removes the reference to
MaterialTheme.colors.isLight
. This is M2 specific, and doesn't exist in M3 in favor of hoisting the decision directly.Second, it replaces
SideEffect
with aDisposableEffect
with keys. I could go either way here, but I'm less of a fan of the implicit nature in howSideEffect
reruns. It's not super obvious that this wouldn't work whenuseDarkIcons
changes: