Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Placeholder] Added M3 Theme Support #1321

Merged
merged 2 commits into from
Jan 8, 2023
Merged

[Placeholder] Added M3 Theme Support #1321

merged 2 commits into from
Jan 8, 2023

Conversation

CaptnBlubber
Copy link
Contributor

This will add an additional module placeholder-material3.
The behavior is Identical to the m2 theme variant

@bentrengrove
Copy link
Collaborator

Thanks for this, we are still working out exactly what to do about this so I will hold this for now

@bentrengrove bentrengrove reopened this Sep 7, 2022
@bentrengrove
Copy link
Collaborator

Any chance you could rebase this on the latest main please?

bentrengrove
bentrengrove requested changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@bentrengrove bentrengrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things to fix up and then we can go ahead and merge this in. Thanks for your help!

gradle/libs.versions.toml Outdated Show resolved Hide resolved
placeholder-material3/build.gradle Show resolved Hide resolved
@AdamMc331
Copy link

Thanks for adding this! I would love to use this in one of my projects. 👏

@CaptnBlubber
Copy link
Contributor Author

Updated to newest M3 stable Version, branch is now in sync with newest commits and addressed mentioned issues

bentrengrove
bentrengrove approved these changes Jan 8, 2023
View reviewed changes
Copy link
Collaborator

@bentrengrove bentrengrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for doing this

@bentrengrove bentrengrove merged commit 0748a0b into google:main Jan 8, 2023
@bentrengrove
Copy link
Collaborator

This will go out in the next release that is happening later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentrengrove bentrengrove bentrengrove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CaptnBlubber @bentrengrove @AdamMc331