Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Placeholder] Deprecating accompanist placeholder #1672

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

florina-muntenescu
Copy link
Collaborator

@florina-muntenescu florina-muntenescu commented Jul 5, 2023

No description provided.

@florina-muntenescu florina-muntenescu changed the title Deprecating accompanist placeholder [Placeholder] Deprecating accompanist placeholder Jul 5, 2023
@alirahimpour89
Copy link
Contributor

Why deprecate this before having a good alternative? 😕 Will miss this one!

@bentrengrove
Copy link
Collaborator

We are currently evaluating the future of some Accompanist libraries. We have decided that the placeholder functionality is easily reproduced and able to be customised via a fork or copy and we can't produce every variant that people would want so it doesn't make sense to upstream it to the main Compose libraries. It makes more sense for people to use it as a reference implementation and create their own that meets their needs. It will still be available here in a deprecated form and is safe to use, but we won't be making any changes to it going forwards unfortunately.

@bentrengrove bentrengrove merged commit f5d2b1e into main Jul 6, 2023
9 checks passed
@bentrengrove bentrengrove deleted the fm/placeholder_deprecation branch July 6, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants