Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick Ignore .mount cgroup & Release v0.24.2 #1615

Merged
merged 2 commits into from
Mar 15, 2017
Merged

Cherrypick Ignore .mount cgroup & Release v0.24.2 #1615

merged 2 commits into from
Mar 15, 2017

Conversation

dashpole
Copy link
Collaborator

@dashpole dashpole commented Mar 14, 2017 •
edited
Loading

Original PR #1573

@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@dashpole dashpole changed the title Release v0.24.2 Cherrypick Ignore .mount cgroup & Release v0.24.2 Mar 14, 2017
@dashpole
Copy link
Collaborator Author

@derekwaynecarr Ok to cherrypick this to 1.4?

@timstclair
Copy link
Contributor

LGTM. Please add a link to the original PR being cherrypicked into this PR description. As long as there aren't any other changes that need to be picked into v24 now, this LGTM.

@dashpole dashpole added the lgtm label Mar 14, 2017
timstclair
timstclair approved these changes Mar 15, 2017
View reviewed changes
Copy link
Contributor

@timstclair timstclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

/cc @derekwaynecarr FYI

@timstclair timstclair merged commit a2ee903 into google:release-v0.24 Mar 15, 2017
@dashpole dashpole deleted the v0.24.2 branch March 15, 2017 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timstclair timstclair timstclair approved these changes

Assignees

@timstclair timstclair

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dashpole @googlebot @timstclair @derekwaynecarr