Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java.nio.ByteOrder as to well-known immutable list #1788

Closed
PhilippWendler opened this issue Aug 19, 2020 · 1 comment · Fixed by #1789
Closed

Add java.nio.ByteOrder as to well-known immutable list #1788

PhilippWendler opened this issue Aug 19, 2020 · 1 comment · Fixed by #1789
Assignees

Comments

@PhilippWendler
Copy link

Description of the problem / feature request:

Please add java.nio.ByteOrder to the list of known immutable types in WellknownMutability.

The class is effectively an enum, although not implemented as such. It is final and does not expose any mutable fields.

Feature requests: what underlying problem are you trying to solve with this feature?

We are using the existing class as an enum for modeling byte orders and would like to store it as a field in other @Immutable classes.

What version of Error Prone are you using?

2.4.0

@kluever kluever self-assigned this Aug 19, 2020
copybara-service bot pushed a commit that referenced this issue Aug 19, 2020
…ownMutability.

The class is effectively an enum, although not implemented as such. It is final and does not expose any mutable fields.

Fixes #1788

PiperOrigin-RevId: 327476333
@PhilippWendler
Copy link
Author

Thanks, that was fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants