-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RestrictTo] @RestrictTo cannot be used outside the support library #812
Comments
RestrictTo check essentially breaks use of |
Fixes #812 RELNOTES: Disable RestrictToEnforcer by default (fixes #812) ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=177328012
What was the resolution on this? Disabling it unblocks people but the check itself seems still wrong, unless google internally prevents anyone from the support library from using that annotation? |
It was simply disabled. The intention of this rule was to prevent apps within Google from using internal android.support.* library methods. Sadly, as implemented it blocks anyone from using |
I'm also not happy with the 'fix' of disabling this rule. |
What's your proposal?
…On Sun, Dec 3, 2017, 10:08 Niklas Baudy ***@***.***> wrote:
I'm also not happy with the 'fix' of disabling this rule.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#812 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABWjyf8OTEC_IQjUPv9LwI0ghlJavStLks5s8uOggaJpZM4QS9gJ>
.
|
I'd like to understand why this was even added in the first place and what's the benefit. |
Can we mark as @GoogleInternal? Why is it even open source if it's unusable
anywhere but internally?
…On Sun, Dec 3, 2017, 2:34 PM Niklas Baudy ***@***.***> wrote:
I'd like to understand why this was even added in the first place and
what's the benefit.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#812 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEEEYWW4j2ZpgMAyQbd_kNWeZeBmr46ks5s8vfdgaJpZM4QS9gJ>
.
|
I'll try to summarize the internal discussion on this.
Android team is also planning to move away from Given all that, I don't this this makes sense for open-source users, and we should make it Google-internal. |
Summary: Fixes #299 See google/error-prone#812 (comment) for further explanation. Reviewed By: IanChilds Differential Revision: D6674126 fbshipit-source-id: c811e9fd0039835488bad70751f02a33f2e9efcd
Has there been any progress on this issue? Marking it as Google internal seems fine to me and should be trivial. |
Fixes #812 RELNOTES: Make RestrictToEnforcer internal-only. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=225617145
The following class gets flagged:
with
[RestrictTo] @RestrictTo cannot be used outside the support library
. The package of the utility class iscom.firebase.geofire
while all of the other things are in a different package. I basically need the Utility class to call a package private function. Is this a false positive?The text was updated successfully, but these errors were encountered: