Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error-prone doesn't work w/ latest javac version #1083

Closed
wants to merge 1 commit into from

Conversation

iignatev
Copy link
Contributor

@iignatev iignatev commented Aug 7, 2018

running error-prone w/ javac from JDK11+ ea build leads to NoSuchMethodErrors b/c error-prone uses a few methods from which have been removed from com/sun/tools/javac/util/AbstractLog by JDK-8196403.

the fix uses JCDiagnostic.Factory::create to create diagnostic objects and Log::report method. to get JCDiagnostic.Factory, I had to propagate an instance of Context in several places.

@cushon cushon self-assigned this Aug 7, 2018
@cushon
Copy link
Collaborator

cushon commented Aug 7, 2018

Thanks! There are a couple of pending changes to finish JDK 10 support, and I'll merge this as soon as that lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants