docstore/all - add support for boolean filter #3446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @vangent, would it be possible to have a review for my CR, please? |
vangent
requested changes
Aug 9, 2024
| @@ -42,6 +42,7 @@ aws dynamodb create-table \ | |||
| AttributeName=Player,AttributeType=S \ | |||
| AttributeName=Score,AttributeType=N \ | |||
| AttributeName=Time,AttributeType=S \ | |||
| AttributeName=WithGlitch,AttributeType=BOOL \ | |||
There was a problem hiding this comment.
This doesn't work, the only possible values are S, N, B. I am not sure what to use for a BOOL value....
Although, the test seems to pass without this so maybe it's not necessary?
There was a problem hiding this comment.
Yes you are correct, I have removed it
| @@ -1485,6 +1486,11 @@ func testGetQuery(t *testing.T, _ Harness, coll *docstore.Collection) { | |||
| q: coll.Query().Where("Player", "not-in", []string{"pat", "billie"}), | |||
| want: func(h *HighScore) bool { return h.Player != "pat" && h.Player != "billie" }, | |||
| }, | |||
| { | |||
| name: "WithGlitch", | |||
There was a problem hiding this comment.
Can you also add tests for "in" and "not-in"?
…s attribute name when creating dynamodb table
|
I have cloned this PR to #3464 and added the AWS and GCP golden test file updates. |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Docstore to allow boolean filters in the queries, as it's supported by all the different implementations.
This isn't yet merge-able as the replay data needs to be re-generated, and I don't have the permission to do it.
I have tested it with Firestore, the local version of MongoDB but haven't tested it with AWS or Azure as I don't have an account.