-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add values-fr folder with French translation of app #2770
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
I'm a bit confused here. Is this going forward now? Checks have failed because it's missing approval only, or is there another problem? |
Thanks @jo-spek ! In order to submit code to this repo you'll need to first accept the Google CLA at https://cla.developers.google.com/clas. Also, the checks are failing due to "Invalid unicode escape sequence in string" on several of the strings. Pasting the actual errors below. Once those are resolved we should be able to approve and merge.
|
@jo-spek I fixed one issue - apparently The best way to resolve all of these issues is to open the project in Android Studio. There you'll see all off the potential issues highlighted inline, e.g.: |
Oh, yes. Quite understandable that ' would cause problems. But the French diacritics are not a problem then? I'll go over it. |
You can also try adding changes in #2771 to your branch. |
No description provided.