Added Date and Time Hint Text #2782
Open
+56
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2782 +/- ##
============================================
+ Coverage 60.85% 61.00% +0.15%
- Complexity 1160 1162 +2
============================================
Files 265 265
Lines 6149 6183 +34
Branches 858 859 +1
============================================
+ Hits 3742 3772 +30
- Misses 1921 1922 +1
- Partials 486 489 +3
|
Comment on lines
+65
to
+74
| val hint = | ||
| pattern | ||
| .replace("yyyy", "YYYY") // Full year | ||
| .replace("yy", "YY") // Short year | ||
| .replace("MMMM", "MMMM") // Full month name | ||
| .replace("MMM", "MMM") // Abbreviated month name | ||
| .replace("MM", "MM") // Month (two-digit numeric) | ||
| .replace("M", "MM") // Single-digit month to two-digit | ||
| .replace("dd", "DD") // Two-digit day | ||
| .replace("d", "DD") // Single-digit day to two-digit |
There was a problem hiding this comment.
Can this be replaced with toUpper()?
Comment on lines
+66
to
+73
| timeFormat | ||
| .toPattern() | ||
| .replace("hh", "HH") // 12-hour format to 2-digit hour (12-hour clock) | ||
| .replace("h", "HH") // 12-hour format to 2-digit hour (12-hour clock) | ||
| .replace("HH", "HH") // 24-hour format | ||
| .replace("mm", "MM") // Minutes (two-digit) | ||
| .replace("ss", "SS") // Seconds (two-digit) | ||
| .replace("a", "AM/PM") // AM/PM indication with a space |
There was a problem hiding this comment.
Same as previous comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2706
@... PTAL?