Skip to content

Commit

Permalink
resolve some warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
leahecole committed Aug 22, 2023
1 parent 6e4311c commit 195540e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/normalCalls/timeout.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export function addServerTimeoutArg(
): SimpleCallbackFunction {
// TODO: this assumes the other arguments consist of metadata and options,
// which is specific to gRPC calls. Remove the hidden dependency on gRPC.
return (argument, callback) => {
return argument => {
const now = new Date();
const options = otherArgs.options || {};
options.deadline = new Date(now.getTime() + timeout);
Expand Down
8 changes: 3 additions & 5 deletions test/test-application/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ async function testServerStreamingRetriesWithShouldRetryFn(
attemptStream.on('data', (response: {content: string}) => {
finalData.push(response.content);
});
attemptStream.on('error', (error: any) => {
attemptStream.on('error', () => {
// Do nothing
});
attemptStream.on('end', () => {
Expand Down Expand Up @@ -760,7 +760,7 @@ async function testServerStreamingRetrieswithRetryRequestOptionsResumptionStrate
attemptStream.on('data', (response: {content: string}) => {
finalData.push(response.content);
});
attemptStream.on('error', (e: any) => {
attemptStream.on('error', () => {
// do nothing
});
attemptStream.on('end', () => {
Expand Down Expand Up @@ -790,9 +790,7 @@ async function testServerStreamingRetrieswithRetryRequestOptionsErrorsOnBadResum
3000,
600000
);
const getResumptionRequestFn = (
originalRequest: protos.google.showcase.v1beta1.AttemptStreamingSequenceRequest
) => {
const getResumptionRequestFn = () => {
// return a bad resumption strategy
return {};
};
Expand Down

0 comments on commit 195540e

Please sign in to comment.