Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otel): avoid infinite trace export loop #14612

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 4, 2024

Fixes #14611

Avoid an infinite export loop when GOOGLE_CLOUD_CPP_OPENTELEMETRY_TRACING is set by never tracing the Cloud Trace client.

While the solution is not good, it seemed less bad than the alternatives listed in the parent issue.


This change is Reviewable

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.59%. Comparing base (36c3aee) to head (8150ba7).
Report is 2 commits behind head on main.

Files Patch % Lines
generator/internal/option_defaults_generator.cc 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14612      +/-   ##
==========================================
- Coverage   93.59%   93.59%   -0.01%     
==========================================
  Files        2316     2316              
  Lines      207108   207115       +7     
==========================================
- Hits       193846   193841       -5     
- Misses      13262    13274      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review August 5, 2024 16:02
@dbolduc dbolduc requested a review from a team as a code owner August 5, 2024 16:02
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dbolduc)

@dbolduc dbolduc merged commit d9adf56 into googleapis:main Aug 6, 2024
70 checks passed
@dbolduc dbolduc deleted the trace-exporter-no-inf-loop branch August 6, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid infinite Cloud Trace export loop
2 participants