feat(spanner/spansql): add support for protobuf column types & Proto bundles #10945
+487
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Spanner supports protobuf message and enum-typed columns and casts, add support for parsing those those types. Since protobuf columns aren't distinguished by a keyword, adjust the parser to see any unquoted identifier that's not a known type as a possible protobuf type and loop, consuming `.`s and identifiers until it hits a non-ident/`.` token. (to match the proto namespace components up through the message or enum names) To track the fully-qualified message/enum type-name add an additional field to the `Type` struct (tentatively) called `ProtoRef` so we can recover the message/enum name if canonicalizing everything.
Add support for parsing and serializing CREATE, ALTER and DROP PROTO BUNDLE DDL statements.
dfinkel
force-pushed
the
spansql_protobuf_column_support
branch
from
8e788c3
to
0c841d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(spansql): CREATE/ALTER/DROP PROTO BUNDLE
Add support for parsing and serializing CREATE, ALTER and DROP PROTO
BUNDLE DDL statements.
feat(spanner/spansql): support for protobuf types
Now that Spanner supports protobuf message and enum-typed columns and
casts, add support for parsing those those types.
Since protobuf columns aren't distinguished by a keyword, adjust the
parser to see any unquoted identifier that's not a known type as a
possible protobuf type and loop, consuming
.s and identifiers until ithits a non-ident/
.token. (to match the proto namespace components upthrough the message or enum names)
To track the fully-qualified message/enum type-name add an additional
field to the
Typestruct (tentatively) calledProtoRefso we canrecover the message/enum name if canonicalizing everything.
closes: #10944