Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exponential backoff when downloading the metadata repository #597

Merged
merged 3 commits into from
May 23, 2024
Merged

Add exponential backoff when downloading the metadata repository #597

merged 3 commits into from
May 23, 2024

Conversation

melix
Copy link
Collaborator

@melix melix commented May 21, 2024

Fixes #592

@melix melix added enhancement New feature or request gradle-plugin Related to Gradle plugin labels May 21, 2024
@melix melix added this to the 0.10.3 milestone May 21, 2024
@melix melix requested review from fniephaus and dnestoro May 21, 2024 15:06
@melix melix self-assigned this May 21, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 21, 2024
dnestoro
dnestoro previously approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@dnestoro dnestoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

fniephaus
fniephaus requested changes May 22, 2024
View reviewed changes
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the missing copyright header. Otherwise lgtm, thanks!

common/utils/src/main/java/org/graalvm/buildtools/utils/ExponentialBackoff.java Outdated Show resolved Hide resolved
common/utils/src/main/java/org/graalvm/buildtools/utils/ExponentialBackoff.java Outdated Show resolved Hide resolved
common/utils/src/test/java/org/graalvm/buildtools/utils/ExponentialBackoffTest.java Show resolved Hide resolved
@melix melix requested a review from fniephaus May 22, 2024 09:45
fniephaus
fniephaus approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fniephaus fniephaus merged commit 096ea1f into graalvm:master May 23, 2024
112 checks passed
@wilkinsona
Copy link

Thanks very much, @melix.

@dnestoro dnestoro mentioned this pull request May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fniephaus fniephaus fniephaus approved these changes

@dnestoro dnestoro dnestoro left review comments

Assignees

@melix melix

Labels
enhancement New feature or request gradle-plugin Related to Gradle plugin OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
0.10.3
Development

Successfully merging this pull request may close these issues.

Add some resiliency to the collection of reachability metadata
4 participants
@melix @wilkinsona @fniephaus @dnestoro