Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release k6 v0.26.0 #1231

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Release k6 v0.26.0 #1231

merged 1 commit into from
Dec 16, 2019

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Nov 8, 2019

No description provided.

@mstoykov mstoykov added this to the v0.26.0 milestone Nov 8, 2019
@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #1231 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1231      +/-   ##
==========================================
+ Coverage   75.42%   75.43%   +0.01%     
==========================================
  Files         150      150              
  Lines       10883    10883              
==========================================
+ Hits         8208     8210       +2     
+ Misses       2209     2207       -2     
  Partials      466      466
Impacted Files Coverage Δ
lib/consts/consts.go 0% <ø> (ø) ⬆️
stats/cloud/collector.go 77.6% <0%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9308833...af6500d. Read the comment docs.

cuonglm
cuonglm previously approved these changes Nov 8, 2019
Copy link
Collaborator

@sniku sniku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My English grammar/spelling is not great, so I just commented on things I found :D
It's probably fine to have some mistakes in the release notes anyway, so it's not a big deal.

release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the inline suggestions and comments, I noticed that we're inconsistently missing dots at the end of sentences in the "Internals" and "Bugs fixed" sections. We had them in previous release notes, because from time to time, you need to fit multiple sentences in one of these list items, for example:

it doesn't make sense to have a dot in the first sentence, but no the second

release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
@na-- na-- requested a review from sniku November 22, 2019 14:46
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/upcoming.md Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
imiric
imiric previously approved these changes Nov 22, 2019
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I pushed a few nitpicks in 97fed04. Feel free to cherry-pick. :)

release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
imiric
imiric previously approved these changes Nov 25, 2019
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the last minor correction, and the PR description, this LGTM now. Feel free to squash everything into a single commit, so we can merge and release 🎉

release notes/v0.26.0.md Outdated Show resolved Hide resolved
cuonglm
cuonglm previously approved these changes Dec 16, 2019
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor suggestions.

release notes/v0.26.0.md Outdated Show resolved Hide resolved
release notes/v0.26.0.md Outdated Show resolved Hide resolved
imiric
imiric previously approved these changes Dec 16, 2019
@na-- na-- merged commit aeec9a7 into master Dec 16, 2019
@na-- na-- deleted the prepare-v0.26.0 branch December 16, 2019 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants