Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the size of the warning from metrics' Add() methods #2219

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Limit the size of the warning from metrics' Add() methods #2219

merged 1 commit into from
Nov 3, 2021

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Nov 2, 2021

fixes #2217

@na-- na-- added this to the v0.35.0 milestone Nov 2, 2021
na--
na-- reviewed Nov 2, 2021
View reviewed changes
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, besides the minor nitpick, but can you please also add a test?

@mstoykov mstoykov force-pushed the fix/limitMetricAddWarnMessage branch from f48e588 to 77e8f20 Compare November 3, 2021 10:02
@na-- na-- changed the title Limit the size of the warning from metrics's Add Limit the size of the warning from metrics' Add() methods Nov 3, 2021
@na-- na-- requested a review from codebien November 3, 2021 14:23
@mstoykov mstoykov merged commit 8328134 into master Nov 3, 2021
@imiric imiric deleted the fix/limitMetricAddWarnMessage branch November 3, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebien codebien codebien approved these changes

@na-- na-- na-- approved these changes

@inancgumus inancgumus Awaiting requested review from inancgumus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.35.0
Development

Successfully merging this pull request may close these issues.

[Bug]: WARN messages can print megabytes of text
3 participants
@mstoykov @codebien @na--