Add GetScenarioOptions method to ExecutorConfig interface
#3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3053 +/- ##
==========================================
+ Coverage 77.01% 77.03% +0.01%
==========================================
Files 229 229
Lines 17065 17066 +1
==========================================
+ Hits 13143 13147 +4
+ Misses 3080 3078 -2
+ Partials 842 841 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
codebien
requested changes
May 5, 2023
imiric
pushed a commit
that referenced
this pull request
May 5, 2023
imiric
force-pushed
the
feat/executorconfig-scenariooptions
branch
from
59d17da
to
2d82729
Compare
codebien
reviewed
May 5, 2023
|
Apparently there's an issue building gotip 😮💨 |
3 tasks
added 2 commits
May 9, 2023 10:32
This simplifies retrieval of ScenarioOptions, since it avoids type assertions of all possible ExecutorConfig implementations. See grafana/xk6-browser#858 (comment)
I'm not adding it to the lib package, since it could possibly result in an import loop (lib -> lib/executor -> lib).
imiric
force-pushed
the
feat/executorconfig-scenariooptions
branch
from
2d82729
to
35af258
Compare
codebien
previously approved these changes
May 9, 2023
Previously, the new scenario `options` field added in #3036 was being serialized to JSON by default, which made it an incompatible change with some of our internal Cloud services that validate the existing configuration structure. This change makes the object optional, and it will only be serialized if it's included in the data.
codebien
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies retrieval of
ScenarioOptions(added in #3036), since it avoids type assertions of all possibleExecutorConfigimplementations. See this comment.I also added an archive test to serialize the scenario options and read them back, which was arguably missing from #3036.