Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: enforce more otel/prometheus aligned names #3448

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Nov 9, 2023

Closes #3065

@mstoykov mstoykov added this to the v0.48.0 milestone Nov 9, 2023
@mstoykov mstoykov added breaking change for PRs that need to be mentioned in the breaking changes section of the release notes documentation-needed A PR which will need a separate PR for documentation labels Nov 9, 2023
metrics/registry.go Outdated Show resolved Hide resolved
Co-authored-by: Oleg Bespalov <oleg.bespalov@grafana.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (0db029a) 73.34% compared to head (3019269) 73.35%.
Report is 5 commits behind head on master.

❗ Current head 3019269 differs from pull request most recent head 498222e. Consider uploading reports for the commit 498222e to get more accurate results

Files Patch % Lines
js/modules/k6/experimental/fs/errors_gen.go 9.09% 19 Missing and 1 partial ⚠️
js/modules/k6/experimental/fs/module.go 84.25% 11 Missing and 9 partials ⚠️
js/modules/k6/experimental/fs/cache.go 55.55% 4 Missing and 4 partials ⚠️
loader/loader.go 78.94% 2 Missing and 2 partials ⚠️
js/modules/k6/experimental/fs/errors.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #3448    +/-   ##
========================================
  Coverage   73.34%   73.35%            
========================================
  Files         261      266     +5     
  Lines       19769    19956   +187     
========================================
+ Hits        14500    14639   +139     
- Misses       4371     4407    +36     
- Partials      898      910    +12     
Flag Coverage Δ
ubuntu 73.29% <80.37%> (+0.03%) ⬆️
windows 73.19% <80.37%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

olegbespalov
olegbespalov previously approved these changes Nov 15, 2023
@mstoykov
Copy link
Contributor Author

I reedited the message while fixing the test as it seemed strange to not start with what it should include and letter needed to become ASCII letter

But we can edit it more or revert it.

@mstoykov mstoykov merged commit c545ad2 into master Nov 16, 2023
22 checks passed
@mstoykov mstoykov deleted the metricNamesBreakingChanges branch November 16, 2023 09:20
@olegbespalov olegbespalov added documentation-needed A PR which will need a separate PR for documentation and removed documentation-needed A PR which will need a separate PR for documentation labels Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes documentation-needed A PR which will need a separate PR for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict metric names to what is supported by Prometheus
4 participants