Address comments

clients/pkg/logentry/stages/metrics.go

@@ -325,7 +325,8 @@ func getFloat(unk interface{}) (float64, error) {
 // getFloatFromString converts string into float64
 // Two types of string formats are supported:
 //   * strings that represent floating point numbers, e.g., "0.804"
-//   * duration format strings, e.g., "0.5ms", "10d".
+//   * duration format strings, e.g., "0.5ms", "10h".
+//     Valid time units are "ns", "us", "ms", "s", "m", "h".
 //     Values in this format are converted as a floating point number of seconds.
 //     E.g., "0.5ms" is converted to 0.0005
 func getFloatFromString(str string) (float64, error) {

clients/pkg/logentry/stages/metrics_test.go

@@ -321,7 +321,7 @@ func TestMetricStage_Process(t *testing.T) {
 			"contains_false":  "contains(keys(@),'nope')",
 		},
 	}
-	regexLogFixture := `11.11.11.11 - frank [25/Jan/2000:14:00:01 -0500] "GET /1986.js HTTP/1.1" 200 932ms"`
+	regexHTTPFixture := `11.11.11.11 - frank [25/Jan/2000:14:00:01 -0500] "GET /1986.js HTTP/1.1" 200 932ms"`
 	regexConfig := map[string]interface{}{
 		"expression": "(?P<get>\"GET).*HTTP/1.1\" (?P<status>\\d*) (?P<time>\\d*ms)",
 	}
@@ -411,7 +411,7 @@ func TestMetricStage_Process(t *testing.T) {
 		t.Fatalf("failed to create stage with metrics: %v", err)
 	}
 	out := processEntries(jsonStage, newEntry(nil, labelFoo, logFixture, time.Now()))
-	out[0].Line = regexLogFixture
+	out[0].Line = regexHTTPFixture
 	out = processEntries(regexStage, out...)
 	out = processEntries(metricStage, out...)
 	out[0].Labels = labelFu