Helm path update #1061
Merged
Helm path update #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this basically needs to sit here for a while until we release Loki v0.4.0 with the new path. I completely missed this in #1049. |
|
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Closed
cyriltovena
force-pushed
the
helm-path-update
branch
from
0ffdf41
to
a3cf4d9
Compare
stale
bot
removed
the
stale
joe-elliott
force-pushed
the
helm-path-update
branch
from
a3cf4d9
to
ca21682
Compare
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
force-pushed
the
helm-path-update
branch
from
ca21682
to
b3886f8
Compare
Signed-off-by: Joe Elliott <number101010@gmail.com>
|
@cyriltovena |
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
…-test Fix TestChunksBasic() to check all chunks returned
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
* Updated helm chart push paths Signed-off-by: Joe Elliott <number101010@gmail.com> * Updated helm chart versions Signed-off-by: Joe Elliott <number101010@gmail.com> * Updated test to use new format when pushing Signed-off-by: Joe Elliott <number101010@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joe Elliott number101010@gmail.com
What this PR does / why we need it:
Helm chart paths were not up to date with the latest Loki paths due to this issue:
#852
This PR moves them forward to the v1 paths and increments the path version of all 3 helm charts.