Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update /loki/api/v1/push to use the v1 json format #1145

Merged
merged 6 commits into from
Oct 15, 2019

Conversation

joe-elliott
Copy link
Member

What this PR does / why we need it:

  • Updates the json format accepted at /loki/api/v1/push to match other v1 endpoints
  • Adds supporting unmarshalling structure and tests
  • Updates documentation to the new format
  • Reverts changes made to

Which issue(s) this PR fixes:
Fixes #1142

Special notes for your reviewer:
Promtail, docker driver and fluentbit clients should all continue to operate normally as they all use protobuf which has not been touched. An issue (#1144) was filed to update the fluentd client.

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott joe-elliott changed the title Push http Update /loki/api/v1/push to use the v1 json format Oct 11, 2019
docs/api.md Show resolved Hide resolved
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rfratto rfratto merged commit bb2b925 into grafana:master Oct 15, 2019
@salvacorts salvacorts mentioned this pull request Jun 29, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change /loki/api/v1/push JSON object to be consistent with other v1 paths
2 participants