Fix compiled logproto protobuf #1181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing to rework it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The PR #1133 has upgraded
golangci-lintand thus theloki-build-imagehas been rebuilded and a new version published (0.7.3).The rebuild of the image has installed the latest versions of the deps specified in the
loki-build-image/Dockerfile, includingprotoc-gen-gogoslickwhich I think is the cause of a change topkg/logproto/logproto.pb.go.We didn't notice it, because in the
Makefilethe%.pb.gotarget is not a phony one, so thelogproto.protois recompiled only once its timestamp change. However, it should be recompiled also whenever the tooling change and it may be quite difficult to remember it, so I'm proposing to add it as a phony target givenprotocis relatively quick. I'm open to any better suggestion, cause I haven't found a better way to enforce it.Special notes for your reviewer:
Checklist