Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ReservedLabelTenantID out from a dedicated file #1239

Conversation

pracucci
Copy link
Contributor

@pracucci pracucci commented Nov 7, 2019

What this PR does / why we need it:

In PR #1135 I've received a last minute comment about the dedicated file for ReservedLabelTenantID. In this PR I'm fixing it, removing the dedicated file and moving the constant to promtail client.

Checklist

  • Documentation added
  • Tests updated

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cyriltovena cyriltovena merged commit 9ec3117 into grafana:master Nov 7, 2019
@pracucci pracucci deleted the move-tenant-id-label-out-from-dedicated-file branch November 7, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants