Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove async cache writeback on chunk fetcher #12456

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

slim-bean
Copy link
Collaborator

What this PR does / why we need it:

PR #5083 introduced async writeback for chunks from the fetcher, however, I think at the time it was overlooked that the cache implementations (memcached and redis are wrapped with a Background cache wrapper which already does async writeback of cache objects.

This PR removes the implementation from #5083 in favor of the Background wrapper which supports additional configurations such as setting a count or size limit of background writes

NOTES: THIS IS A BREAKING CHANGE AS IT DOES REMOVE EXISTING CONFIGS

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@slim-bean slim-bean requested a review from a team as a code owner April 3, 2024 20:15
@slim-bean slim-bean changed the title change!: remote async cache writeback on chunk fetcher change!: remove async cache writeback on chunk fetcher Apr 3, 2024
@slim-bean slim-bean changed the title change!: remove async cache writeback on chunk fetcher refactor!: remove async cache writeback on chunk fetcher Apr 3, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 4, 2024
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 4, 2024
Signed-off-by: Edward Welch <edward.welch@grafana.com>
Signed-off-by: Edward Welch <edward.welch@grafana.com>
Signed-off-by: Edward Welch <edward.welch@grafana.com>
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean slim-bean merged commit 3ece2ea into main Apr 4, 2024
11 checks passed
@slim-bean slim-bean deleted the remove-async-cache branch April 4, 2024 23:36
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Signed-off-by: Edward Welch <edward.welch@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants